From d8747b4c9cbc3f2f29389037e22135ef78f85a2d Mon Sep 17 00:00:00 2001
From: tv <tv@krebsco.de>
Date: Sun, 6 Apr 2025 18:27:14 +0200
Subject: abort on errors and unset variables

---
 request_cert.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/request_cert.sh b/request_cert.sh
index a3d37e2..9ddf042 100644
--- a/request_cert.sh
+++ b/request_cert.sh
@@ -12,7 +12,9 @@
 # Simple Usage: request_cert.sh -s <fqdn>
 #
 
-if [ -z "${VAULT_TOKEN}" ]; then
+set -eu
+
+if [ -z "${VAULT_TOKEN-}" ]; then
    read -p USER: LDAPUSER
    read -s -p PASSWORD: LPDAPASSWD
    VAULT_TOKEN=$( curl -s -X POST -H "Content-Type: application/json" -d "{ \"password\": \"$LPDAPASSWD\"}" https://vault.dings:8200/v1/auth/ldap/login/$LDAPUSER | jq -r ".auth.client_token" )
@@ -20,7 +22,7 @@ if [ -z "${VAULT_TOKEN}" ]; then
 fi
 
 
-if [ -z "$1" ]; then
+if [ -z "${1-}" ]; then
    echo "USAGE: $0 -s <fqdn>|<filename>"
    exit 1
 fi
-- 
cgit v1.2.3