From 90656dbd00c32b56a6082d7baf4fc752adcf85dd Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Fri, 13 Jan 2012 05:49:29 +0800 Subject: lapd: Warn if someone attempts to send an empty message DATA REQ with a msgb_l3len(msg) == 0 message does not make any sense, log an error and return immediately before attempting to send an empty I frame in lapd_send_i. --- src/gsm/lapd_core.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src') diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index 74ffef30..fb79a2f0 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -1731,6 +1731,13 @@ static int lapd_data_req(struct osmo_dlsap_prim *dp, struct lapd_msg_ctx *lctx) struct lapd_datalink *dl = lctx->dl; struct msgb *msg = dp->oph.msg; + if (msgb_l3len(msg) == 0) { + LOGP(DLLAPD, LOGL_ERROR, + "writing an empty message is not possible.\n"); + msgb_free(msg); + return -1; + } + LOGP(DLLAPD, LOGL_INFO, "writing message to send-queue: l3len: %d\n", msgb_l3len(msg)); -- cgit v1.2.3