diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2019-03-06 06:14:01 +0100 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2019-03-06 07:00:30 +0100 |
| commit | 4ea698233aa7f94e53a0bbf09e45506b216e32d4 (patch) | |
| tree | c71847556c64de634e1d13330d2828b90173f0bb /tests/tdef/tdef_test.ok | |
| parent | 4f54c6c48d90ee94c3115a8ea6c60333e398e116 (diff) | |
fix tdef_test.c: do call the function-to-test in all cases
Always call osmo_tdef_fsm_inst_state_chg(), also when no timeout is defined.
When there is no timeout defined for a state, tdef_test.c tries to be smart and
print different output. In that mess, I missed the fact that
osmo_tdef_fsm_inst_state_chg() isn't always called as it should. In the same
mess, the resulting state was never printed until the preceding patch, which
helped to hide this bug.
Change-Id: I1d953d99854422bff8eb32f051e9c6147bc836b6
Diffstat (limited to 'tests/tdef/tdef_test.ok')
| -rw-r--r-- | tests/tdef/tdef_test.ok | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/tests/tdef/tdef_test.ok b/tests/tdef/tdef_test.ok index 1acf0e60..135951e5 100644 --- a/tests/tdef/tdef_test.ok +++ b/tests/tdef/tdef_test.ok @@ -131,16 +131,16 @@ state=A T=1, 76.954322 s remaining Time passes: 23.045678 s state=A T=1, 76.954322 s remaining --> L (configured as T123(keep_timer) 1 s) rc=0; state=L T=123, 76.954322 s remaining - --> O (no timer configured for this state) state=L T=123, 76.954322 s remaining - --> L (configured as T123(keep_timer) 1 s) rc=0; state=L T=123, 76.954322 s remaining + --> O (no timer configured for this state) rc=0; state=O T=0, no timeout + --> L (configured as T123(keep_timer) 1 s) rc=0; state=L T=123, no timeout - test T=0: - --> O (no timer configured for this state) state=L T=123, 76.954322 s remaining + --> O (no timer configured for this state) rc=0; state=O T=0, no timeout - test no timer: - --> X (no timer configured for this state) state=L T=123, 76.954322 s remaining + --> X (no timer configured for this state) rc=0; state=X T=0, no timeout - test undefined timer, using default_val arg of osmo_tdef_fsm_inst_state_chg(), here passed as 999: --> Y (configured as T666 0 -) rc=0; state=Y T=666, 999.000000 s remaining - test disallowed transition: - --> Z (no timer configured for this state) state=Y T=666, 999.000000 s remaining - --> B (configured as T2 100 ms) rc=0; state=B T=2, 1.000000 s remaining - --> C (configured as T3 100 m) rc=0; state=C T=3, 6000.000000 s remaining - --> D (configured as T4 100 custom-unit) rc=0; state=D T=4, 100.000000 s remaining + --> Z (no timer configured for this state) rc=0; state=Z T=0, no timeout + --> B (configured as T2 100 ms) rc=-1; state=Z T=0, no timeout + --> C (configured as T3 100 m) rc=-1; state=Z T=0, no timeout + --> D (configured as T4 100 custom-unit) rc=-1; state=Z T=0, no timeout |